Skip to content

UI: Fix header menu misalignment #6002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2019
Merged

UI: Fix header menu misalignment #6002

merged 2 commits into from
Feb 8, 2019

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Feb 8, 2019

The icons in the '+' menu were misaligned, fixed it by using the same icon classes as on the user menu.

Before

screenshot 2019-02-08 at 08 33 34

After

screenshot 2019-02-08 at 08 33 22

@zeripath
Copy link
Contributor

zeripath commented Feb 8, 2019

I assume this doesn't degrade the mobile view. I'm surprised the fitted was put there.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2019
@silverwind
Copy link
Member Author

silverwind commented Feb 8, 2019

Mobile view looks fine:

screenshot 2019-02-08 at 11 18 43

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Feb 8, 2019
@lafriks lafriks added this to the 1.8.0 milestone Feb 8, 2019
@lunny
Copy link
Member

lunny commented Feb 8, 2019

CI failed.

@adelowo
Copy link
Member

adelowo commented Feb 8, 2019

Failure seems unrelated to this PR

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2019
@codecov-io
Copy link

codecov-io commented Feb 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@db58dba). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6002   +/-   ##
=========================================
  Coverage          ?   38.72%           
=========================================
  Files             ?      332           
  Lines             ?    48992           
  Branches          ?        0           
=========================================
  Hits              ?    18973           
  Misses            ?    27272           
  Partials          ?     2747

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db58dba...3cfcf82. Read the comment docs.

@techknowlogick techknowlogick merged commit c3d8fb7 into go-gitea:master Feb 8, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

8 participants

@silverwind @zeripath @lunny @adelowo @codecov-io @techknowlogick @lafriks @GiteaBot