Update U2F Section of app.ini.sample #5994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
lunny
approved these changes
Feb 7, 2019
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Feb 7, 2019
GiteaBot
added
lgtm/done
lafriks
added
lgtm/need 1
|
no need to backport docs |
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when users copy the default values over to their
app.ini, Gitea crashes on startup due to a panic from the upstream ini module.Perhaps in the future the module will support referencing keys from other non-default sections, but currently it does not.
I commented them out and added a note that users will need to modify them to get them working. I don't particularly love all-caps notes...but without them it blended into the rest of the comments. Let me know if you prefer changes to the wording (or not all caps).
I thought of leaving the values as
%(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s/and just commenting them out, however I didn't want to imply that those values would work.Instead I changed them to what the default values would resolve to,
http://localhost:3000/Affected Issues: #4260 #4692 #5394 #5406 #5526
Resolves #4692
Resolves #5982