Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log output #5938

Merged
merged 1 commit into from
Feb 2, 2019
Merged

fix log output #5938

merged 1 commit into from
Feb 2, 2019

Conversation

saromanov
Copy link
Contributor

Hi! Seems log output for errors should contain method name which it call. Please check my change

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 2, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #5938 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5938      +/-   ##
==========================================
+ Coverage   37.96%   37.97%   +<.01%     
==========================================
  Files         329      329              
  Lines       48406    48406              
==========================================
+ Hits        18379    18383       +4     
+ Misses      27386    27381       -5     
- Partials     2641     2642       +1
Impacted Files Coverage Δ
models/branches.go 43.33% <0%> (ø) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
routers/repo/view.go 47.3% <0%> (+1.19%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ee544...1d47272. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 2, 2019
@zeripath zeripath merged commit 67567ef into go-gitea:master Feb 2, 2019
@saromanov saromanov deleted the fix-log-output branch February 2, 2019 21:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants