-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Better support for long repo names #5932
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5932 +/- ##
==========================================
- Coverage 37.97% 37.96% -0.02%
==========================================
Files 329 329
Lines 48406 48406
==========================================
- Hits 18383 18377 -6
- Misses 27381 27388 +7
+ Partials 2642 2641 -1
Continue to review full report at Codecov.
|
A proper fix for these kind of issues is flexbox, but it does not seem to be possible via |
I think we're happy to migrate to vue as necessary |
It's not vue-specific, you still need CSS (framework or hand-coded), and I think semantic-ui is too fat, outdated, full of weird hacks and (as of late) unmaintained. Maybe one of these: https://bulma.io/ |
I don't think any of the maintainers have a huge amount of time to do a massive UI refactor but I think we're definitely of the opinion that it's time to migrate off semantic UI. The problem is how to do that without breaking everything. If you're able and have the skills I think it's reasonable to do. The only thing I'd say is that you're gonna need lots of screenshots to prove its working. |
Sorry, I don't think I have the motivation and time to do a UI rewrite, but I guess we could gradually move off semantic-ui, e.g. first add lightweight flexbox support (which start with just a couple of helper classes), then start preferring them over semantic for layout purposes. |
Stream of thought follows:
|
A total rewrite is out of question unless someone is willing to invest hundrets of hours, which I'm not. I suggest gradually introducing flexbox where it makes sense, small pieces that can be easily reviewed.
There's no perfect framework. Right now, flexbox layout is popular with css-grid also around the corner. I generally prefer do to things without frameworks because it offers the most control. Frameworks like semantic or bulma are too far abstracted from what is actually happening in CSS. A more modern approach is to use classes that map to exact css properties, and I think this is the way to go. Also, I'm not really a fan of CSS-in-JS because that leads to a lot of duplication. Regarding UI layout testing, I have no experience unfortunately. I may consider becoming a maintainer later, but right now I prefer not to be. |
Can we move your disscussion about a move off semantic ui to a seperate issue to give more people a chance to discuss it? @zeripath @silverwind |
Small template tweak to allow more of the repo name to show without wrapping.
Before
After