Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Jan 31, 2019

will fix #5657

@lunny lunny added the type/bug label Jan 31, 2019
@lunny lunny added this to the 1.8.0 milestone Jan 31, 2019
@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #5912 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5912      +/-   ##
==========================================
+ Coverage   37.96%   37.98%   +0.01%     
==========================================
  Files         329      329              
  Lines       48404    48405       +1     
==========================================
+ Hits        18378    18386       +8     
+ Misses      27385    27378       -7     
  Partials     2641     2641
Impacted Files Coverage Δ
modules/lfs/server.go 44.41% <100%> (+0.13%) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
routers/repo/view.go 47.3% <0%> (+1.19%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0823791...2c179de. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 31, 2019
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have looked at this so many times and missed this. Might be worth sticking a comment in to say users don't necessarily need to be signed in - check for anonymous actress

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 31, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 31, 2019
@lunny
Copy link
Member Author

lunny commented Jan 31, 2019

@zeripath done.

@zeripath zeripath merged commit bbad9b6 into go-gitea:master Jan 31, 2019
@lunny lunny deleted the lunny/lfs_permission branch January 31, 2019 13:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.7.0 lfs regression

5 participants