Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "pulls.blocked_by_approvals" text #5879

Merged
merged 2 commits into from
Jan 28, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jan 28, 2019

Changed

This Pull Request hasn't enough approvals yet. %d of %d approvals granted.

to

This Pull Request doesn't have enough approvals yet. %d of %d approvals granted

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #5879 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5879      +/-   ##
==========================================
- Coverage   37.84%   37.83%   -0.02%     
==========================================
  Files         328      328              
  Lines       48326    48326              
==========================================
- Hits        18290    18283       -7     
- Misses      27404    27410       +6     
- Partials     2632     2633       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
routers/repo/view.go 46.1% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f4a40c...90164fc. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2019
@techknowlogick techknowlogick merged commit 7461c5a into go-gitea:master Jan 28, 2019
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jan 28, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 28, 2019
@adelowo adelowo deleted the update_approval_text branch January 28, 2019 16:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants