Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete correct temp directory #5839

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

yasuokav
Copy link
Contributor

This PR will fix #5829

@codecov-io
Copy link

Codecov Report

Merging #5839 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5839      +/-   ##
==========================================
+ Coverage   37.86%   37.88%   +0.01%     
==========================================
  Files         328      328              
  Lines       48310    48310              
==========================================
+ Hits        18294    18303       +9     
+ Misses      27385    27380       -5     
+ Partials     2631     2627       -4
Impacted Files Coverage Δ
models/pull.go 50.95% <100%> (ø) ⬆️
models/repo_indexer.go 48.3% <0%> (+3.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892bfd0...8ab2aff. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 25, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 25, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2019
@lafriks lafriks added the backport/done All backports for this PR have been created label Jan 25, 2019
@zeripath
Copy link
Contributor

Looks like it's the intermittent MSSQL failure again...

@techknowlogick techknowlogick merged commit d663930 into go-gitea:master Jan 25, 2019
@yasuokav yasuokav deleted the fix-delete-unique-tmpdir branch January 26, 2019 05:05
bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entire "LOCAL_COPY_PATH" directory is getting deleted after a PR was merged
7 participants