Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the releases api paging #5831

Merged
merged 3 commits into from
Jan 24, 2019
Merged

improve the releases api paging #5831

merged 3 commits into from
Jan 24, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 24, 2019

should fix #5336

@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 24, 2019
@lunny lunny added this to the 1.8.0 milestone Jan 24, 2019
@lunny lunny mentioned this pull request Jan 24, 2019
Closed
@codecov-io
Copy link

codecov-io commented Jan 24, 2019 •
edited
Loading

Codecov Report

Merging #5831 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5831      +/-   ##
==========================================
- Coverage   37.86%   37.85%   -0.02%     
==========================================
  Files         328      328              
  Lines       48297    48310      +13     
==========================================
- Hits        18289    18288       -1     
- Misses      27377    27392      +15     
+ Partials     2631     2630       -1
Impacted Files Coverage Δ
modules/setting/setting.go 49.31% <ø> (ø) ⬆️
routers/api/v1/repo/release.go 45.65% <0%> (-2.26%) ⬇️
routers/repo/view.go 46.1% <0%> (-1.2%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a137fa...329d565. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 24, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2019
@lafriks lafriks added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Jan 24, 2019
@lafriks lafriks merged commit 892bfd0 into go-gitea:master Jan 24, 2019
@techknowlogick techknowlogick mentioned this pull request Jan 25, 2019
Merged
bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019
@lunny @bmackinney
improve the releases api paging (go-gitea#5831)
4303a88 
* improve the releases api paging

* add max limit on API paging
@lunny lunny deleted the lunny/list_releases branch November 18, 2020 04:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

ListReleases() In /routers/api/v1/repo/release.go should set lower PageSize for GetReleasesByRepoID()
6 participants
@lunny @codecov-io @techknowlogick @lafriks @bkcsoft @GiteaBot