Request for public keys only if LDAP attribute is set #5816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
approved these changes
Jan 23, 2019
bkcsoft
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #5816 +/- ##
========================================
Coverage ? 37.9%
========================================
Files ? 328
Lines ? 48205
Branches ? 0
========================================
Hits ? 18273
Misses ? 27301
Partials ? 2631
Continue to review full report at Codecov.
|
zeripath
approved these changes
Jan 23, 2019
|
LGTM is stuck :) |
bkcsoft
added
lgtm/done
|
Just one thing - could we adjust the LDAP tests to account for this case so we don't get stung by this again. |
|
@zeripath it's not something really that could be reproduced with tests imho |
|
Fair enough. |
lafriks
added a commit
to lafriks-fork/gitea
that referenced
this pull request
Jan 23, 2019
* Update go-ldap dependency * Request for public keys only if attribute is set
lafriks
added a commit
that referenced
this pull request
Jan 24, 2019
bmackinney
pushed a commit
to bmackinney/gitea
that referenced
this pull request
Jan 27, 2019
* Update go-ldap dependency * Request for public keys only if attribute is set
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #5808