Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix migration 78 error mssql #5791

Merged
merged 1 commit into from
Jan 21, 2019
Merged

fix migration 78 error mssql #5791

merged 1 commit into from
Jan 21, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 21, 2019

As title.

@lunny lunny added the type/bug label Jan 21, 2019
@lunny
Copy link
Member Author

lunny commented Jan 21, 2019

should fix #5789

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 21, 2019
@zeripath
Copy link
Contributor

Does mysql not have if exists? Probably should just add if exists to the other one too.

@codecov-io
Copy link

Codecov Report

Merging #5791 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5791      +/-   ##
==========================================
- Coverage   37.74%   37.73%   -0.01%     
==========================================
  Files         327      327              
  Lines       47849    47849              
==========================================
- Hits        18059    18057       -2     
- Misses      27196    27198       +2     
  Partials     2594     2594
Impacted Files Coverage Δ
models/migrations/v78.go 0% <0%> (ø) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f631702...7949758. Read the comment docs.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 21, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2019
@lunny
Copy link
Member Author

lunny commented Jan 21, 2019

@zeripath mysql don't suport if exist

@lafriks lafriks merged commit b80d649 into go-gitea:master Jan 21, 2019
@lafriks lafriks added this to the 1.8.0 milestone Jan 21, 2019
@lunny lunny deleted the lunny/fix_migration_78_mssql branch January 21, 2019 13:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @zeripath @codecov-io @lafriks @adelowo @bkcsoft