Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bot/stale] Force the PR close time to 60 days #5770

Merged
merged 3 commits into from
Jan 19, 2019

Conversation

sapk
Copy link
Member

@sapk sapk commented Jan 19, 2019

I found a missing param in the stale bot config and it doesn't follow the comment that is posted.

Ex: #4749 is closed after 2 weeks and not 2 months

sapk added 2 commits January 19, 2019 15:33
Like the comment that is posted.

Ex: go-gitea#4749 is closed after 2 weeks and not 2 months
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 19, 2019
@codecov-io
Copy link

codecov-io commented Jan 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ac0d551). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5770   +/-   ##
=========================================
  Coverage          ?   37.72%           
=========================================
  Files             ?      327           
  Lines             ?    47818           
  Branches          ?        0           
=========================================
  Hits              ?    18041           
  Misses            ?    27183           
  Partials          ?     2594

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac0d551...ef9629d. Read the comment docs.

Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I think leaving an issue open for 120 days before closing is perhaps a bit too long. It's kinda bad to say we're not going to close it for 60 days then close it after two weeks...

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2019
@techknowlogick techknowlogick merged commit 905e63f into go-gitea:master Jan 19, 2019
@sapk sapk deleted the fix-close-time-pr branch January 20, 2019 14:08
@sapk
Copy link
Member Author

sapk commented Jan 20, 2019

@zeripath current settings are for PR and issue.
2 months inactivity -> stale tag
And for issue after 2 weeks without response the bot close
And for PR it wait another 2 months before closing.

The goal was at start to not frustate potential contributor but we could decrease the time after.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants