Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong assumption where a user is always said to have unassigned (her)himself #5769

Merged
merged 2 commits into from
Jan 19, 2019
Merged

fix wrong assumption where a user is always said to have unassigned (her)himself #5769

merged 2 commits into from
Jan 19, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jan 19, 2019 •
edited
Loading

Fixes #4418

screenshot 2019-01-19 at 14 30 37

@adelowo
fix wrong assumption where a user is always said to have unassigned (…
d990628 
…her)himself

fix wording where there is a self unassignment
@codecov-io
Copy link

codecov-io commented Jan 19, 2019 •
edited
Loading

Codecov Report

Merging #5769 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5769      +/-   ##
==========================================
+ Coverage   37.72%   37.73%   +<.01%     
==========================================
  Files         327      327              
  Lines       47818    47818              
==========================================
+ Hits        18040    18043       +3     
+ Misses      27183    27181       -2     
+ Partials     2595     2594       -1
Impacted Files Coverage Δ
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 905e63f...5821b2d. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 19, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 19, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2019
@zeripath zeripath merged commit c212c98 into go-gitea:master Jan 19, 2019
@adelowo adelowo deleted the fix_wording_when_a_user_is_unassigned branch January 19, 2019 19:41
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Removing assignments doesn't show correct attribution
6 participants
@adelowo @codecov-io @lunny @zeripath @techknowlogick @bkcsoft