Skip to content

Log IP of failed ssh connection #5766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2019
Merged

Log IP of failed ssh connection #5766

merged 1 commit into from
Jan 19, 2019

Conversation

@Whisprin
Copy link
Contributor

@Whisprin Whisprin commented Jan 19, 2019

Targets issue #5765

Log the IP address of a connecting remote machine in case of a SSH connection error for the built-in ssh server.

@Whisprin
Log IP of failed ssh connection
96bb0d3 
Signed-off-by: Robert Sprunk <github@sprunk.me>
@codecov-io
Copy link

codecov-io commented Jan 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@af45648). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5766   +/-   ##
=========================================
  Coverage          ?   37.77%           
=========================================
  Files             ?      327           
  Lines             ?    47818           
  Branches          ?        0           
=========================================
  Hits              ?    18061           
  Misses            ?    27165           
  Partials          ?     2592
Impacted Files Coverage Δ
modules/ssh/ssh.go 48.9% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af45648...96bb0d3. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 19, 2019
zeripath
zeripath approved these changes Jan 19, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a sensible improvement

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 19, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2019
@zeripath zeripath merged commit 65b6ebf into go-gitea:master Jan 19, 2019
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jan 20, 2019
@lafriks lafriks added this to the 1.8.0 milestone Jan 20, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Whisprin @codecov-io @lunny @zeripath @lafriks @bkcsoft