-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to blame files #5721
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5721 +/- ##
=========================================
- Coverage 40.87% 40.8% -0.08%
=========================================
Files 416 418 +2
Lines 57013 57274 +261
=========================================
+ Hits 23303 23368 +65
- Misses 30589 30783 +194
- Partials 3121 3123 +2
Continue to review full report at Codecov.
|
Even though I don't like current approach of git methods being in different repository but to be consistent git operations should be moved to go-gitea/git probably |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya! Thanks for your first PR. It's a good idea to add this functionality, but see my comments.
Do you consider adding screenshots to this PR? |
@jonasfranz Done |
Screenshot feedback:
|
Does this work 'recursive, e.g. clicking on a commit on the left side opens a blame of this file with the context of the commit? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
Any news? |
Do the links in the blame view go to the commit (e.g. show an overview of that particular commit) or to the same file in the clicked commit, opening the blame view again? |
OK this is still rendering the whole blame in memory but I guess we can probably fix this later and get it more efficient once it's in. |
"strings" | ||
|
||
"code.gitea.io/gitea/models" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary blank line.
@lafriks I think we also need commit time with the author? |
Few ideas:
|
Signed-off-by: Andrzej Ressel <jereksel@gmail.com>
Signed-off-by: Andrzej Ressel <jereksel@gmail.com>
Signed-off-by: Andrzej Ressel <jereksel@gmail.com>
Signed-off-by: Andrzej Ressel <jereksel@gmail.com>
Signed-off-by: Andrzej Ressel <jereksel@gmail.com>
Signed-off-by: Andrzej Ressel <jereksel@gmail.com>
@lunny please review |
@jereksel @lafriks good work. If you can move git parts to |
there is a bounty for this PR: https://www.bountysource.com/issues/41291710-feautre-request-git-blame |
Introduces option to blame text files.
closes #747
Regarding https://github.com/go-gitea/gitea/pull/5721/files#diff-4c18d74f0d0687b8503915779673f3ebR393 - width was set to 1%, but it seems to scale anyway.