Improve "Fork button" for guests by showing a pop up asking them to log in before forking #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to login and if authentication was successful, the user will be redirected to fork the repo
Codecov Report
@@ Coverage Diff @@
## master #5690 +/- ##
=========================================
Coverage ? 37.77%
=========================================
Files ? 323
Lines ? 47595
Branches ? 0
=========================================
Hits ? 17977
Misses ? 27029
Partials ? 2589Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lafriks
approved these changes
Jan 10, 2019
|
What happened to the lgtm bot :) Edit — Is the bot supposed to consider the PR creator’s “lgtm” ? |
bkcsoft
added
lgtm/need 1
|
@adelowo that's a bug of the bot. |
lunny
approved these changes
Jan 11, 2019
bkcsoft
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users fork a repo even as a guest. This will prompt the user to log in and if authentication was successful, the user will be redirected to fork the repo
Fixes #4798