Skip to content

fix bug when a read perm user to edit his issue #5516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2018
Merged

fix bug when a read perm user to edit his issue #5516

merged 2 commits into from
Dec 12, 2018

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 11, 2018

Will fix #4168

@lunny lunny added this to the 1.7.0 milestone Dec 11, 2018
@codecov-io
Copy link

codecov-io commented Dec 11, 2018 •
edited
Loading

Codecov Report

Merging #5516 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5516      +/-   ##
==========================================
+ Coverage   37.57%   37.57%   +<.01%     
==========================================
  Files         319      319              
  Lines       46949    46949              
==========================================
+ Hits        17641    17642       +1     
+ Misses      26798    26795       -3     
- Partials     2510     2512       +2
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6bce3...38875be. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2018
@lunny lunny mentioned this pull request Dec 11, 2018
Closed
7 tasks
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2018
@lunny lunny mentioned this pull request Dec 12, 2018
Closed
7 tasks
@lunny
Copy link
Member Author

lunny commented Dec 12, 2018

will also fix #4755

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2018
@techknowlogick techknowlogick merged commit f0374ad into go-gitea:master Dec 12, 2018
lunny added a commit to lunny/gitea that referenced this pull request Dec 12, 2018
@lunny
fix bug when a read perm user to edit his issue (go-gitea#5516)
6a694fd
@lunny lunny mentioned this pull request Dec 12, 2018
Merged
@lunny lunny deleted the lunny/fix_read_perm_edit branch December 12, 2018 16:51
@lunny lunny added the backport/done All backports for this PR have been created label Dec 12, 2018
techknowlogick pushed a commit that referenced this pull request Dec 12, 2018
@lunny @techknowlogick
fix bug when a read perm user to edit his issue (#5516) (#5534)
800271e
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@Bwko Bwko Bwko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

Can not edit issue description after creation

6 participants

@lunny @codecov-io @lafriks @Bwko @techknowlogick @bkcsoft