Skip to content

Conversation

@techknowlogick
Copy link
Member

As title

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 28, 2018
@gaydin
Copy link

gaydin commented Nov 28, 2018

Is it possible to upgrade to 3.8 too?

FROM golang:1.11-alpine3.7 AS build-env

@techknowlogick
Copy link
Member Author

@gaydin yup. Thank you for the suggestion. I've updated.

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #5423 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5423      +/-   ##
==========================================
- Coverage   37.55%   37.54%   -0.01%     
==========================================
  Files         317      317              
  Lines       46832    46832              
==========================================
- Hits        17588    17585       -3     
- Misses      26744    26746       +2     
- Partials     2500     2501       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc805c...7271bff. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2018
@techknowlogick techknowlogick merged commit 5c13ba8 into go-gitea:master Nov 29, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-9 branch November 29, 2018 02:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants