Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 9, 2018

When a user are on two teams on the same organization and get units will get non-current repository teams and units. This pull request will add a filter so that a repository get units only the repository's teams, not all the teams of the user.

@lunny lunny added this to the 1.7.0 milestone Nov 9, 2018
@codecov-io
Copy link

Codecov Report

Merging #5307 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5307      +/-   ##
==========================================
+ Coverage   37.36%   37.38%   +0.02%     
==========================================
  Files         312      312              
  Lines       46322    46330       +8     
==========================================
+ Hits        17309    17322      +13     
+ Misses      26531    26527       -4     
+ Partials     2482     2481       -1
Impacted Files Coverage Δ
models/repo.go 43.55% <100%> (ø) ⬆️
models/org_team.go 52.09% <100%> (+0.81%) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599adde...0787463. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 9, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 9, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 9, 2018
@lafriks lafriks merged commit c5d098c into go-gitea:master Nov 9, 2018
@lafriks
Copy link
Member

lafriks commented Nov 9, 2018

@lunny please send backport

@lunny lunny deleted the lunny/fix_team_unit branch November 9, 2018 08:09
lunny added a commit to lunny/gitea that referenced this pull request Nov 9, 2018
@lunny lunny added the backport/done All backports for this PR have been created label Nov 9, 2018
lunny added a commit that referenced this pull request Nov 9, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants