-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove maxlines option for file logger #5282
Conversation
Looks good. I'd use something around 100 MB which comes closer to the initial 1 million lines. |
Codecov Report
@@ Coverage Diff @@
## master #5282 +/- ##
==========================================
- Coverage 37.38% 37.37% -0.01%
==========================================
Files 312 312
Lines 46327 46313 -14
==========================================
- Hits 17320 17311 -9
+ Misses 26525 26520 -5
Partials 2482 2482
Continue to review full report at Codecov.
|
@lafriks milestone 1.7.0? Since it's a fix for a performance-critical issue, I'd appreciate to see it in 1.6. edit: sorry, did not see the backport label. |
Isn't 256MB still large enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems sensible. Logrotate and log4j do not have this option either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would deprecate it and print a warning that it no longer does anything. Otherwise LGTM
@bkcsoft the breaking label should indicate this in the changelog. |
It's not documented anywhere and it would print on every git ssh operation, so I don't really see how we could deprecate it |
@lafriks Shouldn't I see this backport in https://github.com/go-gitea/gitea/commits/release/v1.6 now? |
For further consideration, maybe we should use other maintained-well log library rather than we maintained a new one. |
To support this feature it requires scanning whole log file on every ssh git operation that is not sensible. Remove this feature as there is already option for file size that is more reasonable to use and other log file rotation options.
Should fix #4450