Fix home page template regression #5102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 7bb4d61 tries to take the app_name from the locale, however, it is a user defined setting. This causes the app name to simply display as `app_name` instead of the correct value. templates/helper.go automatically injects the AppName variable into every template, so we can safely use that instead. Signed-off-by: Daniel Derzsi <daniel@tohka.us>
Codecov Report
@@ Coverage Diff @@
## master #5102 +/- ##
==========================================
- Coverage 37.4% 37.39% -0.01%
==========================================
Files 307 307
Lines 45552 45552
==========================================
- Hits 17037 17034 -3
- Misses 26060 26062 +2
- Partials 2455 2456 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
jonasfranz
approved these changes
Oct 18, 2018
bkcsoft
added
lgtm/need 1
jonasfranz
added
type/bug
issue/regression
kolaente
approved these changes
Oct 18, 2018
bkcsoft
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 7bb4d61 tries to take the app_name from the locale, however, it is a user defined setting. This causes the app name to simply display as
app_nameinstead of the correct value.templates/helper.go automatically injects the AppName variable into every template, so we can safely use that instead.
Right now, the home page looks like this: https://i.imgur.com/aZKaotf.png