Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show email if the authenticated user owns the profile page being requested for #4981

Merged
merged 12 commits into from
Feb 19, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Sep 26, 2018

Also removed setting.UI.ShowUserEmail as it's documentation says it
only controls the email setting on the explore page

Would fix broken CI, this was pushed in a quick rush

routers/user/profile.go Outdated Show resolved Hide resolved
@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 26, 2018
@jonasfranz jonasfranz added the type/enhancement An improvement of existing functionality label Sep 30, 2018
@jonasfranz jonasfranz added this to the 1.7.0 milestone Sep 30, 2018
requested for.

Also removed `setting.UI.ShowUserEmail` as it's documentation says it
only controls the email setting on the explore page
@techknowlogick techknowlogick modified the milestones: 1.7.0, 1.8.0 Dec 19, 2018
@adelowo
Copy link
Member Author

adelowo commented Jan 30, 2019

Bummer, will update this PR

Will sure do this over the new week

@codecov-io
Copy link

Codecov Report

Merging #4981 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4981      +/-   ##
==========================================
+ Coverage   38.84%   38.86%   +0.02%     
==========================================
  Files         349      349              
  Lines       49801    49801              
==========================================
+ Hits        19344    19354      +10     
+ Misses      27657    27646      -11     
- Partials     2800     2801       +1
Impacted Files Coverage Δ
routers/user/profile.go 33.33% <100%> (ø) ⬆️
routers/repo/http.go 39.78% <0%> (-0.81%) ⬇️
models/user.go 49.85% <0%> (+0.46%) ⬆️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️
routers/repo/view.go 45.68% <0%> (+1.14%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff2be17...8049add. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2019
@techknowlogick techknowlogick merged commit 094263d into go-gitea:master Feb 19, 2019
@adelowo adelowo deleted the dont_hide_email_from_self branch February 19, 2019 14:29
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants