Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord Oauth2 support #4476

Merged
merged 15 commits into from
Jan 13, 2019
Merged

Discord Oauth2 support #4476

merged 15 commits into from
Jan 13, 2019

Conversation

techknowlogick
Copy link
Member

Fix #4125

@techknowlogick techknowlogick added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jul 19, 2018
@techknowlogick techknowlogick added this to the 1.6.0 milestone Jul 19, 2018
@codecov-io
Copy link

codecov-io commented Jul 19, 2018

Codecov Report

Merging #4476 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4476      +/-   ##
==========================================
- Coverage   37.75%   37.75%   -0.01%     
==========================================
  Files         325      325              
  Lines       47638    47640       +2     
==========================================
- Hits        17988    17986       -2     
- Misses      27056    27061       +5     
+ Partials     2594     2593       -1
Impacted Files Coverage Δ
models/oauth2.go 35.55% <ø> (ø) ⬆️
modules/auth/oauth2/oauth2.go 22.79% <0%> (-0.35%) ⬇️
models/unit.go 0% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beab2df...e0dd14a. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 19, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 20, 2018
@lafriks
Copy link
Member

lafriks commented Jul 20, 2018

Conflict

@jonasfranz
Copy link
Member

If I try to authenticate via Discord, I'm getting this error:

2018/07/20 10:44:54 [...routers/user/auth.go:542 handleOAuth2SignIn()] [E] UserSignIn: oauth2: cannot fetch token: 401 Unauthorized
Response: {"error": "invalid_client"}

I've created a discord application and added the secrets. Then I've added the redirect link to OAuth2 at Discord.

@techknowlogick
Copy link
Member Author

@JonasFranzDEV thanks for testing. I just tested and can confirm same results. Using same keys with goth example I was able to login, so it is 100% something wrong with my implementation. I'll go through and see what I did wrong.

@l0go
Copy link

l0go commented Jul 20, 2018

yay!

@techknowlogick techknowlogick added the pr/wip This PR is not ready for review label Jul 20, 2018
@techknowlogick techknowlogick modified the milestones: 1.6.0, 1.x.x Aug 29, 2018
@techknowlogick techknowlogick removed the pr/wip This PR is not ready for review label Jan 12, 2019
@techknowlogick
Copy link
Member Author

@jonasfranz I've update vendored dependency, and I am successfully able to login now, please review.

@techknowlogick techknowlogick modified the milestones: 1.x.x, 1.8.0 Jan 12, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 13, 2019
@techknowlogick techknowlogick merged commit 5c44f75 into go-gitea:master Jan 13, 2019
@techknowlogick techknowlogick deleted the discord-auth branch January 13, 2019 19:06
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord Oauth2 support
6 participants