Fix milestone appliance and permission checks #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing permission check Signed-off-by: Jonas Franz <info@jonasfranz.software>
Codecov Report
@@ Coverage Diff @@
## master #4271 +/- ##
==========================================
- Coverage 19.97% 19.96% -0.02%
==========================================
Files 153 153
Lines 30523 30530 +7
==========================================
- Hits 6097 6094 -3
- Misses 23512 23521 +9
- Partials 914 915 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lunny
requested changes
Jun 19, 2018
routers/api/v1/repo/issue.go
Outdated
| } | ||
| return | ||
| } else { | ||
| // setting labels is only allowed if user is writter |
There was a problem hiding this comment.
comment should be ... is not a writer.
|
Otherwise LGTM |
bkcsoft
added
lgtm/need 1
|
@techknowlogick added copyright |
techknowlogick
approved these changes
Jun 19, 2018
bkcsoft
added
lgtm/done
sapk
approved these changes
Jun 19, 2018
lunny
approved these changes
Jun 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4270 and adds missing permission check which got removed.
Without the permission check every user can assign labels, etc to new issues if created via API.