Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swagger security part #4236

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Fix swagger security part #4236

merged 1 commit into from
Jun 12, 2018

Conversation

sapk
Copy link
Member

@sapk sapk commented Jun 12, 2018 •
edited
Loading

Fix #4010 not catched security part in #4220

@sapk sapk mentioned this pull request Jun 12, 2018
Closed
@MikeRalphson
Copy link

Unofficial LGTM (passes the swagger2openapi validator).

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2018
@codecov-io
Copy link

Codecov Report

Merging #4236 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4236   +/-   ##
=======================================
  Coverage   19.96%   19.96%           
=======================================
  Files         153      153           
  Lines       30521    30521           
=======================================
  Hits         6094     6094           
  Misses      23513    23513           
  Partials      914      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8c0bb...364c2a7. Read the comment docs.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 12, 2018
@lafriks lafriks added type/bug type/docs This PR mainly updates/creates documentation modifies/api This PR adds API routes or modifies them labels Jun 12, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2018
@techknowlogick techknowlogick added this to the 1.5.0 milestone Jun 12, 2018
@techknowlogick techknowlogick merged commit 6efdcae into go-gitea:master Jun 12, 2018
@sapk sapk deleted the fix-security-swagger branch June 12, 2018 23:42
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

API fails swagger validation
6 participants
@sapk @MikeRalphson @codecov-io @techknowlogick @lafriks @bkcsoft