Skip to content

Fix #4081 Check for leading / in base before removing it #4082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2018
Merged

Fix #4081 Check for leading / in base before removing it #4082

merged 1 commit into from
May 30, 2018
+8 −2

Conversation

@sapk
Copy link
Member

@sapk sapk commented May 30, 2018 •
edited
Loading

And add more tests related to this func.

Fix #4081

@codecov-io
Copy link

Codecov Report

Merging #4082 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4082   +/-   ##
=======================================
  Coverage   19.97%   19.97%           
=======================================
  Files         153      153           
  Lines       30491    30491           
=======================================
  Hits         6091     6091           
  Misses      23486    23486           
  Partials      914      914
Impacted Files Coverage Δ
modules/util/util.go 29.26% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f6ec9...5263cdb. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 30, 2018
@lafriks lafriks added this to the 1.5.0 milestone May 30, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 30, 2018
@jonasfranz
Copy link
Member

Needs backport

@sapk sapk mentioned this pull request May 30, 2018
Merged
@lunny lunny merged commit 35c3510 into go-gitea:master May 30, 2018
@sapk sapk deleted the fix-absolute-path-url branch May 30, 2018 13:44
@lafriks lafriks added the backport/done All backports for this PR have been created label May 31, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@Bwko Bwko Bwko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

Many links broken

7 participants

@sapk @codecov-io @jonasfranz @lafriks @Bwko @lunny @bkcsoft