Uniform an abstract notification layer for ui, mail, action, webhook and indexer #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
pr/wip
Codecov Report
@@ Coverage Diff @@
## master #4001 +/- ##
==========================================
+ Coverage 20.18% 20.21% +0.03%
==========================================
Files 156 156
Lines 31168 30837 -331
==========================================
- Hits 6292 6235 -57
+ Misses 23918 23658 -260
+ Partials 958 944 -14
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
daviian
suggested changes
May 21, 2018
| receiver notification.NotifyReceiver = &indexerReceiver{} | ||
| ) | ||
|
|
||
| func ini() { |
There was a problem hiding this comment.
Think this should be init here as well
| receiver notification.NotifyReceiver = &actionReceiver{} | ||
| ) | ||
|
|
||
| func ini() { |
routers/api/v1/repo/pull.go
Outdated
| @@ -8,6 +8,8 @@ import ( | |||
| "fmt" | |||
| "strings" | |||
|
|
|||
| "code.gitea.io/gitea/modules/notification" | |||
|
|
|||
There was a problem hiding this comment.
Why is this in a separate import paragraph?
appleboy
reviewed
May 21, 2018
| package webhook | ||
|
|
||
| import ( | ||
| "code.gitea.io/git" |
There was a problem hiding this comment.
code.gitea.io/git is an external package?
There was a problem hiding this comment.
Yes, it is not inside of gitea. IMO
lunny
force-pushed
the
lunny/notification
branch
3 times, most recently
from
8ffa982
to
796805c
Compare
lunny
force-pushed
the
lunny/notification
branch
from
159abc0
to
8b6c568
Compare
This was referenced Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an event occupied, many notifications will be fired. This PR uniforms them as an abstract notification layer so that you can easily add new events or new receivers and don't change the codes of event occupied.