Skip to content

Fix typo in deleteUser #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2018
Merged

Fix typo in deleteUser #3781

merged 1 commit into from
Apr 10, 2018

Conversation

@michaelkuhn
Copy link
Contributor

@michaelkuhn michaelkuhn commented Apr 10, 2018

num_watches was used where num_stars should have been used.

@michaelkuhn
Fix typo in deleteUser
e080c07 
num_watches was used where num_stars should have been used.
@codecov-io
Copy link

codecov-io commented Apr 10, 2018

Codecov Report

Merging #3781 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3781   +/-   ##
=======================================
  Coverage   22.91%   22.91%           
=======================================
  Files         124      124           
  Lines       24755    24755           
=======================================
  Hits         5672     5672           
  Misses      18221    18221           
  Partials      862      862
Impacted Files Coverage Δ
models/user.go 23.49% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a9cda...e080c07. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 10, 2018
@lunny lunny added the type/bug label Apr 10, 2018
@lunny lunny added this to the 1.5.0 milestone Apr 10, 2018
@lunny
Copy link
Member

lunny commented Apr 10, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 10, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 10, 2018
@appleboy appleboy merged commit f321980 into go-gitea:master Apr 10, 2018
@appleboy
Copy link
Member

appleboy commented Apr 10, 2018

@michaelkuhn please send a backport to v1.4.1

@michaelkuhn michaelkuhn mentioned this pull request Apr 10, 2018
Merged
lunny pushed a commit that referenced this pull request Apr 11, 2018
@michaelkuhn @lunny
Fix typo in deleteUser (#3781) (#3783)
31c0a33 
num_watches was used where num_stars should have been used.
@lafriks lafriks added the backport/done All backports for this PR have been created label Apr 11, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

7 participants

@michaelkuhn @codecov-io @lunny @appleboy @techknowlogick @lafriks @bkcsoft