Pull request review/approval and comment on code

[lafriks]

This is merge of my started work on PR approval feature and @lunny comment on code.

Will obsolete #2583 and resolve #124 and #3580

Screenshot:

Work needs to be done:

• Implement UI for code review and comments
• Implement database changes and needed handlers
• Review display in comment section
• Add tests

EDIT by @JonasFranzDEV :
TODOs and other stuff from the merged PR lafriks/gitea#2:

This comment will summarize all progress and updates.

Reviews

Reviews should bundle all code comments created for the initial review. All code comments created for this review are linked to the review model.

Comment types

CommentTypeCode: A comment at a line of a code of a PR
CommentTypeReview: Notifies the participants about the review

TODO

• Render code comments on the right place
• Add support for comments on both sides
• Show code comments in the "conversation" after a review got submitted
• Show single code comment in the "conversation" (won't be implemented, because it would make the comment list bloated. GitHub only shows single comments in the diff view too)
• Remove dummy data from "code comment form" (line, path, side)
• Add support for "Add single comments"
• Order/Separate code comments by thread/review (not implemented, see Order code comments by review #4389)
  • At the moment only the first comment for a line gets shown in the conversation. No replies!
• Blocked by Add line blame git#116
• Edit comments
• Delete comments
• Show actions / notifications for review comments
• Show actions / notifications for review (without comments) (not implemented, see Send notifications until review gets submitted #4388)
• Fix some problems with invalidating comments written for the previous code
• Improve UI
  • Show comments only on one side (split view)
  • "Cancel" button functionality
  • Show add comment button only at PR diff views
  • Show forms only to signed in users
  • Preview tab is broken
  • Add icon is shown at hunk line

Preview(s)

EDIT END

[sapk]

Maybe we could try to store it in git-appraise in place of database ?
You seem to have work on it in #733 and it iwill also obsolete it.

[lafriks]

@sapk that won't be that easy. That was my first idea when starting to work on git-appraise but the problem is how to integrate it with gitea forks & PR's architecture. For now everything will be stored in database and later I will see how to get it all working together also with git-appraise.

[jonasfranz]

What is the difference between "Add single comment" and "Add comment"?

[lafriks]

@JonasFranzDEV it will not show both buttons. Add single comment will be visible only when no review is started and will add comment without starting new review. When you have already started review (added at least one code comment with Start review only buttons Cancel and Add comment will be visible

[lunny]

All the code review buttons are not available.

[jonasfranz]

I'm currently trying to contribute to this PR by creating a PR at @lafriks repo. I already did some progress there. Feel free to check it out: https://github.com/lafriks/gitea/pull/2

[jonasfranz]

@appleboy resolved

[adelowo]

🥇 🥇

[Caballerog]

Is in the actual release?

Docker pull in 3, 2, 1 ...

Thanks.

[chupasaurus]

@Caballerog this feature will be released in next (1.6) release.

[ptman]

@chupasaurus has 1.5.0 been released yet?

[chupasaurus]

@ptman Nope, not yet. Check this link to see how Gitea release cycle looks like.

[mkienenb]

@Caballerog If you are impatient to try it out but don't want to build it from source, you can grab it from here the master release link [1] and install it over your existing binary as described [2] in the "Updating to a new version" section.

[1]
https://dl.gitea.io/gitea/master/

[2]
https://docs.gitea.io/en-us/install-from-binary/

That's what I did.

Thank you everyone else for making this happen!

[sondr3]

@chupasaurus Gitea always takes a bit longer than predicted to release, partially I think because they accept too many features each release. This has been discussed before in #2283 and probably lots of other places as well 😃

[lunny]

@sondr3 I think there are two main reasons. One is what you said, another is all of the maintainers are part-time for the project.

[sondr3]

That too, I do not envy you the task of maintaining a project of this size, I have one with a magnitude less users and that was still stressful and took a lot of time. Don’t worry about it, it’s a minor quibble.

[olekukonko]

when is the ETA for this functionality?

[lafriks]

It is already available for quite some time now. Starting with 1.6.0 version

[olekukonko]

Thanks for the prompt response.

[frankgerhardt]

Nice feature. I have tried both "Request Change" and "Approve" but really got lost as a reviewer when there were newer commits by the developers. Older comments where shown as out of date but for me as reviewer still valid. I could not see how to track all comments and progress on cleaning them up. Is there any documentation about the workflow? Any blog posts or anything else to understand how this shall be used?