Skip to content

Conversation

@jonasfranz
Copy link
Member

@jonasfranz jonasfranz commented Mar 19, 2018

Fix XSS part of #3681 by removing safe from BranchName in the dropdown menu.

Requires backport to 1.4.

Signed-off-by: Jonas Franz <info@jonasfranz.software>
@codecov-io
Copy link

Codecov Report

Merging #3691 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3691      +/-   ##
==========================================
- Coverage    35.8%   35.79%   -0.02%     
==========================================
  Files         287      287              
  Lines       41489    41489              
==========================================
- Hits        14857    14852       -5     
- Misses      24445    24450       +5     
  Partials     2187     2187
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 56.37% <0%> (-1.35%) ⬇️
models/repo_indexer.go 48.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28bf94...61ce616. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2018
@lafriks
Copy link
Member

lafriks commented Mar 19, 2018

It would been better to use escape just for branch name

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2018
@lunny lunny added the type/bug label Mar 19, 2018
@lunny lunny modified the milestones: 1.4.0, 1.5.0 Mar 19, 2018
@lunny lunny added backport/done All backports for this PR have been created backport/v1.4 labels Mar 19, 2018
@lunny lunny merged commit 59e70c5 into go-gitea:master Mar 19, 2018
@jonasfranz jonasfranz deleted the escape-branch-name branch March 19, 2018 17:56
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants