Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update markbates/goth libary to fix OAuth2 support #3661

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Update markbates/goth libary to fix OAuth2 support #3661

merged 1 commit into from
Mar 12, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Mar 12, 2018 •
edited
Loading

Temporary use fork github.com/go-gitea/goth while upstream is not fixed. Fixes #3652 and #3644

@lafriks lafriks added this to the 1.5.0 milestone Mar 12, 2018
@codecov-io
Copy link

Codecov Report

Merging #3661 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3661   +/-   ##
======================================
  Coverage    35.9%   35.9%           
======================================
  Files         286     286           
  Lines       41312   41312           
======================================
  Hits        14832   14832           
+ Misses      24299   24298    -1     
- Partials     2181    2182    +1
Impacted Files Coverage Δ
models/repo_indexer.go 48.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575c109...141604a. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 12, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 12, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 12, 2018
@lafriks lafriks merged commit ad33730 into go-gitea:master Mar 12, 2018
@lafriks lafriks deleted the fix/oauth2_goth branch March 12, 2018 23:35
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Mar 12, 2018
@lafriks
Update markbates/goth libary to fix OAuth2 support (go-gitea#3661)
19c1032
@lafriks lafriks added the backport/done All backports for this PR have been created label Mar 12, 2018
This was referenced Mar 12, 2018
Closed
Merged
lafriks added a commit that referenced this pull request Mar 13, 2018
@lafriks
Update markbates/goth libary to fix OAuth2 support (#3661) (#3663)
0c61212
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkcsoft bkcsoft bkcsoft approved these changes

@Bwko Bwko Bwko approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Error 500 when trying to use GitHub authentication
5 participants
@lafriks @codecov-io @bkcsoft @Bwko @tboerger