Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add feed for organization #3594

Merged
merged 6 commits into from
Mar 3, 2018
Merged

fix: Add feed for organization #3594

merged 6 commits into from
Mar 3, 2018

Conversation

appleboy
Copy link
Member

fixed #3593

screenshot:

snip20180228_8

@appleboy appleboy added this to the 1.5.0 milestone Feb 28, 2018
@appleboy appleboy changed the title feat: Add feed for organization fix: Add feed for organization Feb 28, 2018
@codecov-io
Copy link

codecov-io commented Feb 28, 2018

Codecov Report

Merging #3594 into master will decrease coverage by <.01%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3594      +/-   ##
==========================================
- Coverage   36.15%   36.14%   -0.01%     
==========================================
  Files         285      285              
  Lines       40910    40921      +11     
==========================================
  Hits        14789    14789              
- Misses      23948    23958      +10     
- Partials     2173     2174       +1
Impacted Files Coverage Δ
models/repo_watch.go 67.56% <18.18%> (-8.63%) ⬇️
models/repo_list.go 65.62% <0%> (-1.57%) ⬇️
models/repo_indexer.go 48.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990709d...bd6a675. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2018
Copy link
Contributor

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. One question though: I remember that back when I used gogs, the organization itself that owned the repository was among the watchers of the repos, although this does not seem to be the case anymore. Was it deliberately removed? Why?

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 2, 2018
@appleboy
Copy link
Member Author

appleboy commented Mar 3, 2018

@thehowl Thanks for your review. I don't know why it can't work for the current version. It is working before v1.3 version reported from someone in #chinese channel of discord.

@lunny
Copy link
Member

lunny commented Mar 3, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2018
@appleboy appleboy merged commit 78b54b4 into go-gitea:master Mar 3, 2018
@appleboy appleboy deleted the bugs-1 branch March 3, 2018 05:21
HenrikSolver pushed a commit to HenrikSolver/gitea that referenced this pull request Apr 29, 2018
* feat: Add feed for organization

* fix: testing

* fix: testing

* fix: testing

* fix: testing
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't get all member activity in org dashboard page
5 participants