Allow foreachref parser to grow its buffer #35365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes go-gitea#35221. Firstly, lets the scanner's buffer grow up to 4x (256 kiB) instead of being limited to 64 kiB, which is too small for the commit message mentioned in the issue report. Secondly, adds an error check as recommended by the documentation: https://pkg.go.dev/bufio#Scanner.Scan
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Aug 27, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Aug 27, 2025
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Signed-off-by: Fabian Meyer <fabian.meyer@lawo.com>
wxiaoguang
approved these changes
Aug 28, 2025
GiteaBot
added
lgtm/done
wxiaoguang
added
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Aug 29, 2025
Fixes go-gitea#35221, let the scanner's buffer grow up to 4x (256 kiB), and add an error check --------- Signed-off-by: Fabian Meyer <fabian.meyer@lawo.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
added a commit
that referenced
this pull request
Aug 29, 2025
hiifong
added a commit
to hiifong/gitea
that referenced
this pull request
Aug 31, 2025
* main: (34 commits) when sorting issues by nearest due date, issues without due date should be sorted ascending (go-gitea#35267) [skip ci] Updated translations via Crowdin Upgrade xz to v0.5.15 (go-gitea#35377) Refactor db package (go-gitea#35380) Remove the duplicated function GetTags (go-gitea#35375) [skip ci] Updated translations via Crowdin Allow foreachref parser to grow its buffer (go-gitea#35365) Remove global context from db package (go-gitea#35371) Use gitrepo.SetDefaultBranch when set default branch of wiki repository (go-gitea#33911) Deleting branch could delete broken branch which has database record but git branch is missing (go-gitea#35360) Remove incorrect "db.DefaultContext" usages (go-gitea#35366) Refactor to use reflect.TypeFor (go-gitea#35370) [skip ci] Updated translations via Crowdin Remove wrong "git.DefaultContext" (go-gitea#35364) Fix context usages (go-gitea#35348) Instance signing rule `pubkey` should allow all public keys, not just GPG (go-gitea#35357) Allow deleting comment with content via API like web did (go-gitea#35346) Prevent duplicate actions email (go-gitea#35215) rename nightly docker tag for main branch (go-gitea#35344) Fix atom/rss mixed error (go-gitea#35345) ... # Conflicts: # tests/integration/pull_merge_test.go
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 1, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin when sorting issues by nearest due date, issues without due date should be sorted ascending (go-gitea#35267) [skip ci] Updated translations via Crowdin Upgrade xz to v0.5.15 (go-gitea#35377) Refactor db package (go-gitea#35380) Remove the duplicated function GetTags (go-gitea#35375) [skip ci] Updated translations via Crowdin Allow foreachref parser to grow its buffer (go-gitea#35365) Remove global context from db package (go-gitea#35371) Use gitrepo.SetDefaultBranch when set default branch of wiki repository (go-gitea#33911) Deleting branch could delete broken branch which has database record but git branch is missing (go-gitea#35360)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35221. Firstly, lets the scanner's buffer grow up to 4x (256 kiB) instead of being limited to 64 kiB, which is too small for the commit message mentioned in the issue report. Secondly, adds an error check as recommended by the documentation: https://pkg.go.dev/bufio#Scanner.Scan