-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add running with falure status #35025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I don't think it is well-designed and don't see why it is a must. Please correct me if I was wrong: #34823 (comment) |
There is a bug there. The job cannot be cancelled when it's running with failure because the aggregated status is failure not running. ref #35000 (comment) |
Then it needs to detect the "cancel-able" basing on non-aggregated status? |
However, it would still be strange if a failed task could be cancelled. Alternatively, we could consider merging #35000. The waiting status, similar to running, should have higher priority than failure during aggregation. |
I think I have explained in #34823 (comment), job status and commit status indeed should have different state priorities. correct me if I was wrong |
#35000 is just for job status not for commit status. |
Yes it is, so what's the problem? |
No description provided.