Don't create default column when viewing project columns #34878
+56
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
It was written intentionally to make sure legacy project issues (with no implicit default column) can be properly migrated to new system, and make the system can self-heal even if the default board missing (assign an issue to a new project which doesn't have default column) I guess you broke the old design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing a project column, if there is no column, a default column will be created but not display in the UI. When refresh the page, the column will be displayed. It seems uncomfortable for me.
This PR will not create default column when viewing project columns. Now the default column will only be created when adding an issue to an empty project(there is no any column).
Please review with whitespaces ignored. https://github.com/go-gitea/gitea/pull/34878/files?diff=unified&w=1