-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes missing avatars in offline mode #3471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Codruț Constantin Gușoi <codrut.gusoi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3471 +/- ##
==========================================
- Coverage 35.69% 35.68% -0.01%
==========================================
Files 281 281
Lines 40706 40708 +2
==========================================
- Hits 14528 14527 -1
- Misses 24028 24030 +2
- Partials 2150 2151 +1
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Feb 7, 2018
lafriks
approved these changes
Feb 8, 2018
tboerger
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Feb 8, 2018
Bwko
approved these changes
Feb 8, 2018
tboerger
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3464.
I got the idea for this fix from here.
Aparently in offline mode the avatar filename is already set before it is generated and this line overwrote it every time.