Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML escape all lines of the search result #3402

Merged
merged 2 commits into from
Jan 22, 2018
Merged

HTML escape all lines of the search result #3402

merged 2 commits into from
Jan 22, 2018

Conversation

thehowl
Copy link
Contributor

@thehowl thehowl commented Jan 20, 2018

Fixes #3383

@lafriks lafriks added type/bug topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! labels Jan 20, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 20, 2018
@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 20, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@00d0847). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3402   +/-   ##
=========================================
  Coverage          ?   35.63%           
=========================================
  Files             ?      281           
  Lines             ?    40552           
  Branches          ?        0           
=========================================
  Hits              ?    14449           
  Misses            ?    23969           
  Partials          ?     2134
Impacted Files Coverage Δ
modules/search/search.go 76.82% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d0847...dff6980. Read the comment docs.

@lafriks lafriks merged commit d644e88 into go-gitea:master Jan 22, 2018
@thehowl thehowl deleted the fix-3383 branch April 22, 2018 20:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ethantkoenig ethantkoenig ethantkoenig approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Repo indexer - empty results for specific documents
5 participants
@thehowl @codecov-io @lafriks @ethantkoenig @tboerger