-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run goimports on the whole project #34
Conversation
LGTM |
1 similar comment
LGTM |
Could you please rebase and fix conflicts ? |
Please rebase as @strk mentioned. |
"testing" | ||
|
||
"bytes" | ||
. "github.com/gogits/gogs/modules/markdown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope
"testing" | ||
|
||
"bytes" | ||
. "github.com/gogits/gogs/modules/markdown" | ||
"github.com/gogits/gogs/modules/setting" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope
"testing" | ||
|
||
. "github.com/gogits/gogs/models" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be changed
"testing" | ||
|
||
. "github.com/gogits/gogs/models" | ||
"github.com/gogits/gogs/modules/markdown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Current coverage is 2.18% (diff: 100%)@@ master #34 diff @@
========================================
Files 31 31
Lines 7508 7508
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 164 164
Misses 7327 7327
Partials 17 17
|
Recreated the commit with the current |
When opening this repository in my editor, I run goimports automatically. This is what it found.