Use issue number/index instead of id for API URL. Fix #3297 #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the API calls, the issue objects retrieved by
/repos/{owner}/{repo}/issues
contains the wrong value in the "url" field:
it uses the "id" value instead of the "number" value.
For instance, in a new repo in try.gitea.io with just one issue:
[{
"id": 896,
"url": "https://try.gitea.io/api/v1/repos/AlbertoGP/uno/issues/896",
"number": 1,
...
}]
The given URL does not work, but if you replace the "896" by "1" it
does.
Codecov Report
@@ Coverage Diff @@
## master #3298 +/- ##
==========================================
- Coverage 34.81% 34.62% -0.19%
==========================================
Files 277 277
Lines 40271 40271
==========================================
- Hits 14021 13945 -76
- Misses 24189 24282 +93
+ Partials 2061 2044 -17
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
lafriks
approved these changes
Jan 3, 2018
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
|
will fix #3297 |
7 tasks
Merged
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.