Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed asterisk based tasklist items #3295 #3296

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Fixed asterisk based tasklist items #3295 #3296

merged 1 commit into from
Jan 3, 2018

Conversation

modmew8
Copy link
Contributor

@modmew8 modmew8 commented Jan 3, 2018 •
edited
Loading

Fixed the possibility to use asterisk in tasklists as described in #3295.

Also fixed the requirement for one character after the blank of - [ ] .

@modmew8
Fixed asterisk based tasklist items, fixed requirement for one char a…
f86ef29 
…fter last blank to be a valid task.

Signed-off-by: modmew8 <modmew8@gmail.com>
@modmew8 modmew8 changed the title Fixed asterisk based tasklist items, fixed requirement for one char a… Fixed asterisk based tasklist items #3295 Jan 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #3296 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3296     +/-   ##
=========================================
- Coverage   34.81%   34.62%   -0.2%     
=========================================
  Files         277      277             
  Lines       40271    40271             
=========================================
- Hits        14021    13943     -78     
- Misses      24189    24284     +95     
+ Partials     2061     2044     -17
Impacted Files Coverage Δ
models/issue.go 44.43% <ø> (ø) ⬆️
modules/lfs/content_store.go 7.81% <0%> (-35.94%) ⬇️
modules/lfs/server.go 20.68% <0%> (-14.33%) ⬇️
models/lfs.go 26.08% <0%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5057c6b...f86ef29. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 3, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 3, 2018
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 3, 2018
@lafriks lafriks merged commit 9f8349a into go-gitea:master Jan 3, 2018
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jan 3, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 3, 2018
@modmew8 modmew8 deleted the progressbarAsterisk branch February 5, 2018 15:24
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ethantkoenig ethantkoenig ethantkoenig approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@modmew8 @codecov-io @ethantkoenig @lafriks @tboerger