Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Libravatar by default in new installations #3287

Merged
merged 5 commits into from
Jan 7, 2018

Conversation

strk
Copy link
Member

@strk strk commented Jan 2, 2018

Pre-existing installs still have it default to off.
This is consistent with OpenID setting.

Pre-existing installs still have it default to off.
This is consistent with OpenID setting.
@strk strk force-pushed the libravatar-on-for-new-installs branch from f9322a3 to 03f57fe Compare January 2, 2018 13:21
@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 2, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 5, 2018
@codecov-io
Copy link

codecov-io commented Jan 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@87f67fd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3287   +/-   ##
=========================================
  Coverage          ?   35.08%           
=========================================
  Files             ?      279           
  Lines             ?    40526           
  Branches          ?        0           
=========================================
  Hits              ?    14218           
  Misses            ?    24207           
  Partials          ?     2101
Impacted Files Coverage Δ
modules/setting/setting.go 47.06% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f67fd...9ff7707. Read the comment docs.

@lafriks lafriks added this to the 1.4.0 milestone Jan 6, 2018
@lafriks lafriks merged commit 6a6439c into go-gitea:master Jan 7, 2018
@strk strk deleted the libravatar-on-for-new-installs branch January 7, 2018 10:28
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants