Add more additional template snippets #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
added
type/enhancement
|
LGTM |
tboerger
added
the
lgtm/need 1
bkcsoft
reviewed
Jan 2, 2018
| @@ -130,9 +130,13 @@ | |||
| {{template "custom/header" .}} | |||
| </head> | |||
| <body> | |||
| {{template "custom/body_outer_pre" .}} | |||
There was a problem hiding this comment.
@bkcsoft just following the already existing templates custom/header.tmpl and custom/footer.tmpl.
There was a problem hiding this comment.
root@dchi: ~
<o> # tree /var/lib/docker/volumes/demo_gitea/_data/templates
/var/lib/docker/volumes/demo_gitea/_data/templates
└── base
├── head.tmpl
├── head.tmpl.master
├── head.tmpl.new
└── head.tmpl.patch
bkcsoft
approved these changes
Jan 2, 2018
|
LG-TM doesn't update on approvals 😢 |
tboerger
added
lgtm/done
It updated? |
|
@tboerger only after commenting :( |
Codecov Report
@@ Coverage Diff @@
## master #3286 +/- ##
==========================================
+ Coverage 34.6% 34.82% +0.21%
==========================================
Files 277 277
Lines 40263 40263
==========================================
+ Hits 13935 14021 +86
+ Misses 24283 24183 -100
- Partials 2045 2059 +14
Continue to review full report at Codecov.
|
|
Please see the webhook setting. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we are able to add additional custom temmplate content more easily. A good example is https://try.gitea.io where we place a notice at the top, currently we are overwriting the header template and we are lacking changes if the template gets updated.