Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open external tracker in blank window, consistently with wiki #3227

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Open external tracker in blank window, consistently with wiki #3227

merged 1 commit into from
Dec 19, 2017

Conversation

strk
Copy link
Member

@strk strk commented Dec 18, 2017

Closes #3216

@strk
Copy link
Member Author

strk commented Dec 18, 2017

#3228 is the backport of this for 1.3 branch

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 18, 2017
@strk strk mentioned this pull request Dec 18, 2017
Closed
@codecov-io
Copy link

Codecov Report

Merging #3227 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3227      +/-   ##
==========================================
- Coverage   34.87%   34.86%   -0.01%     
==========================================
  Files         277      277              
  Lines       40014    40014              
==========================================
- Hits        13955    13951       -4     
- Misses      24038    24040       +2     
- Partials     2021     2023       +2
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo.go 41.28% <0%> (-0.19%) ⬇️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e384c6...a5bf9e8. Read the comment docs.

@bkcsoft
Copy link
Member

bkcsoft commented Dec 18, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Dec 19, 2017
@lunny lunny added this to the 1.4.0 milestone Dec 19, 2017
@lunny
Copy link
Member

lunny commented Dec 19, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2017
@lunny lunny merged commit 7e59587 into go-gitea:master Dec 19, 2017
@strk strk deleted the external-tracker-in-new-tab branch December 19, 2017 07:28
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

External wiki link opens in new window/tab, external issue link does not
5 participants
@strk @codecov-io @bkcsoft @lunny @tboerger