Allow agit -o force-push work like -o force-push=true

[lunny]

Fix #16679

Docs update: https://gitea.com/gitea/docs/pulls/80

[wxiaoguang]

The code should be re-used, and other options should also use the better behavior.

And new code (at least GitPushOptions.Bool) should be tested.

[lunny]

The code should be re-used, and other options should also use the better behavior.

And new code (at least GitPushOptions.Bool) should be tested.

I don't think we can use GitPushOptions.Bool here because -o force-push will get false but we think it should be true.

[wxiaoguang]

The code should be re-used, and other options should also use the better behavior.
And new code (at least GitPushOptions.Bool) should be tested.

I don't think we can use GitPushOptions.Bool here because -o force-push will get false but we think it should be true.

The code should be re-used, and other options should also use the better behavior.

GitPushOptions.Bool should be improved but not introducing more unmaintainable code.

[wxiaoguang]

And one more question, how does -o force-push work? In code, I could only find if len(kv) == 2 { hookOptions.GitPushOptions[kv[0]] = kv[1] }

So, how could force-push be put into GitPushOptions?

[wxiaoguang]

I don't think we can use GitPushOptions.Bool here because -o force-push will get false but we think it should be true.

And one more question, if you make -o force-push work (new behavior), then what -o repo.private should mean? Should it still mean "repo.private" option exists but its value is false and the repo should be made as public (the old behavior)?

That's a messy design.

[wxiaoguang]

I will write a correct one.

[wxiaoguang]

-> Make git push options accept short name #32245