Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve suppressed diff boxes #3193

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

silverwind
Copy link
Member

Some general improvements to the suppressed diff boxes:

  • Made text fit on one line
  • Added the "View file" button
  • Added rounded borders around the box using a new CSS helper class
  • Fixed an unclear issue with the diff bars where they would not render the green part

Before

screen shot 2017-12-14 at 18 50 31

After

screen shot 2017-12-14 at 19 15 33

@codecov-io
Copy link

Codecov Report

Merging #3193 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3193      +/-   ##
==========================================
+ Coverage   34.71%   34.71%   +<.01%     
==========================================
  Files         276      276              
  Lines       39975    39975              
==========================================
+ Hits        13877    13879       +2     
+ Misses      24103    24102       -1     
+ Partials     1995     1994       -1
Impacted Files Coverage Δ
models/repo_indexer.go 51.94% <0%> (-1.95%) ⬇️
models/repo.go 41.47% <0%> (+0.18%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94c1b3...2fc8998. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 14, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 14, 2017
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Dec 14, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 14, 2017
@lafriks
Copy link
Member

lafriks commented Dec 14, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 14, 2017
@lafriks lafriks merged commit 1687aa5 into go-gitea:master Dec 14, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants