Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label docs-update-needed for PRs that modify app.example.ini #31810

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Add label docs-update-needed for PRs that modify app.example.ini #31810

merged 2 commits into from
Aug 9, 2024

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Aug 9, 2024

To help #31536.

Or it's easy to forget to update https://gitea.com/gitea/docs when modifying app.example.ini.

@wolfogre wolfogre added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 9, 2024
@wolfogre wolfogre added this to the 1.23.0 milestone Aug 9, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 9, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2024
This was referenced Aug 9, 2024
Merged
Merged
@silverwind
Copy link
Member

Would remove the modifies/ prefix. That is only meant to indicate the file type that was changed and docs-update-needed is not a file type.

@wolfogre
Copy link
Member Author

wolfogre commented Aug 9, 2024 •
edited
Loading

Would remove the modifies/ prefix. That is only meant to indicate the file type that was changed and docs-update-needed is not a file type.

It makes sense.

d2e032a

wolfogre
wolfogre commented Aug 9, 2024
View reviewed changes
.github/labeler.yml Outdated Show resolved Hide resolved
silverwind
silverwind approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Please create label on the repo yourself. If you can't, I can do it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 9, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 9, 2024
@lunny lunny merged commit fb271d1 into go-gitea:main Aug 9, 2024
26 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 11, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
494abf6 
* giteaofficial/main:
  Show lock owner instead of repo owner on LFS setting page (go-gitea#31788)
  Move repository visibility to danger zone in the settings area (go-gitea#31126)
  [skip ci] Updated translations via Crowdin
  Add types to various low-level functions (go-gitea#31781)
  Add warning message in merge instructions when `AutodetectManualMerge` was not enabled (go-gitea#31805)
  Show latest run when visit /run/latest (go-gitea#31808)
  Fix typo for `LOG_COMPRESSION` in ini (go-gitea#31809)
  Add label `docs-update-needed` for PRs that modify `app.example.ini` (go-gitea#31810)
  Fix `IsObjectExist` with gogit (go-gitea#31790)
  Support compression for Actions logs (go-gitea#31761)
  Add issue comment when moving issues from one column to another of the project (go-gitea#29311)
  [skip ci] Updated translations via Crowdin
  Fix RPM resource leak (go-gitea#31794)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wolfogre @silverwind @lunny @GiteaBot