Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix source download link when no code unit allowed #3166

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Fix source download link when no code unit allowed #3166

merged 1 commit into from
Dec 12, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 12, 2017

will fix #3165

@lunny lunny added the type/bug label Dec 12, 2017
@lunny lunny added this to the 1.4.0 milestone Dec 12, 2017
@codecov-io
Copy link

Codecov Report

Merging #3166 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3166      +/-   ##
==========================================
+ Coverage   34.74%   34.74%   +<.01%     
==========================================
  Files         276      276              
  Lines       39945    39945              
==========================================
+ Hits        13878    13880       +2     
+ Misses      24073    24071       -2     
  Partials     1994     1994
Impacted Files Coverage Δ
models/repo.go 41.47% <0%> (ø) ⬆️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f27a646...554cba6. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 12, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 12, 2017
@lafriks
Copy link
Member

lafriks commented Dec 12, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2017
@lafriks lafriks merged commit e3f8871 into go-gitea:master Dec 12, 2017
@lafriks
Copy link
Member

lafriks commented Dec 12, 2017

@lunny please backport

@lunny lunny deleted the lunny/fix_download_source_no_code_unit branch December 12, 2017 06:47
lunny added a commit to lunny/gitea that referenced this pull request Dec 12, 2017
@lunny
fix source download link when no code unit allowed (go-gitea#3166)
1b899c8
@lunny lunny mentioned this pull request Dec 12, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Dec 12, 2017
@lunny
Copy link
Member Author

lunny commented Dec 12, 2017

@lafriks done.

appleboy pushed a commit that referenced this pull request Dec 12, 2017
@lunny @appleboy
Fix source download link when no code unit allowed (#3166) (#3169)
aee45d0
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Release should not display source download if user have no code unit allowed.
5 participants
@lunny @codecov-io @ethantkoenig @lafriks @tboerger