Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS dependencies #31616

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Update JS dependencies #31616

merged 1 commit into from
Jul 11, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jul 11, 2024

Result of make update-js. Tested all dependencies. Lockfile diff is because of npm/cli#7475.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 11, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 11, 2024
@lunny
Copy link
Member

lunny commented Jul 11, 2024

Should we upload those icons which haven't been used?

@silverwind
Copy link
Member Author

silverwind commented Jul 11, 2024

There is no mechanism that filters out unused icons, and I don't think we should have one as those unused icons could still be used in other places like custom templates etc.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 11, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 11, 2024
@techknowlogick techknowlogick merged commit a06bbcf into go-gitea:main Jul 11, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jul 11, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 11, 2024
@silverwind silverwind deleted the deps-79 branch July 11, 2024 18:45
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 12, 2024
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Display app name in the registration email title (go-gitea#31562)
  typo on date in security document (go-gitea#31617)
  Update JS dependencies (go-gitea#31616)
  Add types for js globals (go-gitea#31586)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants