Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to change mail from user display name #31528

Merged
merged 38 commits into from
Jul 14, 2024
Merged

Add option to change mail from user display name #31528

merged 38 commits into from
Jul 14, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 29, 2024 •
edited
Loading

Make it posible to let mails show e.g.:

Max Musternam (via gitea.kithara.com) <gitea@kithara.com>

Docs: https://gitea.com/gitea/docs/pulls/23

Sponsored by Kithara Software GmbH

@6543 6543 added type/enhancement An improvement of existing functionality status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR pr/wip This PR is not ready for review labels Jun 29, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 29, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 29, 2024
@6543 6543 changed the title Mke from user mail format changable Add option to change mail from user display name Jun 29, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2024
@6543 6543 marked this pull request as ready for review July 4, 2024 15:11
@6543 6543 removed the pr/wip This PR is not ready for review label Jul 4, 2024
@6543 6543 requested a review from silverwind July 10, 2024 11:48
@silverwind
Copy link
Member

Did you commit my change? It does not look like it based on current diff.

@6543
Copy link
Member Author

6543 commented Jul 10, 2024

Yes to https://gitea.com/gitea/docs/pulls/23

@silverwind
Copy link
Member

Ok, but keep app.example.ini in sync as well.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 11, 2024
@6543 6543 requested a review from lunny July 11, 2024 22:38
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2024
@6543 6543 merged commit 0f53324 into go-gitea:main Jul 14, 2024
26 checks passed
@6543 6543 deleted the mke-from-user-mail-format-changable branch July 14, 2024 21:27
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jul 14, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bf21df7 
* giteaofficial/main:
  Code editor theme enhancements (go-gitea#31629)
  Add option to change mail from user display name (go-gitea#31528)
  Upgrade xorm to v1.3.9 and improve some migrations Sync (go-gitea#29899)
  Issue Templates: add option to have dropdown printed list (go-gitea#31577)
  Fix update flake (go-gitea#31626)
silverwind added a commit to techknowlogick/gitea that referenced this pull request Jul 23, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into nolyfill
48fdc78 
* origin/main: (59 commits)
  fix OIDC introspection authentication (go-gitea#31632)
  Enable direnv (go-gitea#31672)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  fix redis dep (go-gitea#31662)
  add skip secondary authorization option for public oauth2 clients (go-gitea#31454)
  Fix a branch divergence cache bug (go-gitea#31659)
  [skip ci] Updated translations via Crowdin
  Remove unneccessary uses of `word-break: break-all` (go-gitea#31637)
  [skip ci] Updated translations via Crowdin
  Allow searching issues by ID (go-gitea#31479)
  allow synchronizing user status from OAuth2 login providers (go-gitea#31572)
  Enable `no-jquery/no-class-state` (go-gitea#31639)
  Added default sorting milestones by name (go-gitea#27084)
  Code editor theme enhancements (go-gitea#31629)
  Add option to change mail from user display name (go-gitea#31528)
  Upgrade xorm to v1.3.9 and improve some migrations Sync (go-gitea#29899)
  Issue Templates: add option to have dropdown printed list (go-gitea#31577)
  Fix update flake (go-gitea#31626)
  [skip ci] Updated translations via Crowdin
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @silverwind @lunny @GiteaBot