Document possible action types for the user activity feed API #31196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/api
|
An example:
|
kemzeb
commented
May 31, 2024
| UserID int64 `json:"user_id"` // Receiver user | ||
| // the type of action | ||
| // | ||
| // enum: create_repo,rename_repo,star_repo,watch_repo,commit_repo,create_issue,create_pull_request,transfer_repo,push_tag,comment_issue,merge_pull_request,close_issue,reopen_issue,close_pull_request,reopen_pull_request,delete_tag,delete_branch,mirror_sync_push,mirror_sync_create,mirror_sync_delete,approve_pull_request,reject_pull_request,comment_pull,publish_release,pull_review_dismissed,pull_request_ready_for_review,auto_merge_pull_request |
There was a problem hiding this comment.
This does add some duplication and takes a lot of horizontal space, but haven't found better ways of handling both of these concerns yet. Open to other ideas
There was a problem hiding this comment.
Normally inside a JSON schema, one would use $ref to deduplicate, but I'm almost sure go-swagger does not support ref definition in source annotations, at least I could not find anything regarding it on http://goswagger.io/go-swagger/.
lunny
approved these changes
May 31, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
May 31, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 4, 2024
* giteaofficial/main: Add option for mailer to override mail headers (go-gitea#27860) Move custom `tw-` helpers to tailwind plugin (go-gitea#31184) Remove unnecessary inline style for tab-size (go-gitea#31224) Document possible action types for the user activity feed API (go-gitea#31196) Remove sqlite-viewer and using database client (go-gitea#31223) Update golangci-lint to v1.59.0 (go-gitea#31221)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31131.
It uses the the go-swagger
enumproperty to document the activity action types.