Simplify mirror repository API logic #30963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-api-mirror
branch
from
3f8e9dc to
86d275a
Compare
github-actions
bot
added
modifies/api
lunny
approved these changes
May 13, 2024
GiteaBot
added
lgtm/need 1
yardenshoham
approved these changes
May 17, 2024
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 17, 2024
wxiaoguang
added a commit
that referenced
this pull request
May 18, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 20, 2024
* giteaofficial/main: Fix "force private" logic (go-gitea#31012) [skip ci] Updated licenses and gitignores Improve reverse proxy documents and clarify the AppURL guessing behavior (go-gitea#31003) Fix bug on avatar (go-gitea#31008) Clean up revive linter config, tweak golangci output (go-gitea#30980) Simplify mirror repository API logic (go-gitea#30963)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30921
Some clients keeps sending
EnablePrune=falseto the server, so old code would always fail for non-mirror repositories.Actually, reporting a lot of errors doesn't really help end users. It could simply skip the update if the repo is not a mirror.